fix(sharing): show more board sharing targets and clarify the picker label#8121
Open
maxemig wants to merge 1 commit into
Open
fix(sharing): show more board sharing targets and clarify the picker label#8121maxemig wants to merge 1 commit into
maxemig wants to merge 1 commit into
Conversation
…label The board sharing picker supports users, groups, and teams, but it only requested 20 autocomplete results and displayed the first 10 unallocated entries. This may give the impression that only users are supported. Raise both limits to 200 and use a more specific picker label to clarify the supported sharing targets. The 200-result limit follows established behaviour in Calendar, Tasks, and Bookmarks. Signed-off-by: Max Emig <github@emigm.ax>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The board sharing picker supports users, groups, and teams, but it only requested 20 autocomplete results and displayed the first 10 unallocated entries. This may give the impression that only users are supported.
Raise both limits to 200 and use a more specific picker label to clarify the supported sharing targets.
The 200-result limit follows established behaviour in Calendar, Tasks, and Bookmarks.
Summary
In my local Nextcloud instance, I was only ever suggested 10 users for sharing a board with, the label Select account with the absence of any suggested groups led me to believe that group-sharing was not supported.
It turned out, after searching existing groups are found just fine.
Two improvements to resolve that UI/UX gripe, bump the limit to 200 displayed users/groups/teams to share a board with in line with Calendar, Tasks, and Bookmarks and clarify in the label that teams and groups are also supported.
TODO
n/a
Checklist